examples: Reuse not_current_context in resumed() handler
#1687
Conversation
|
CC @marc2332 @ErichDonGubler, note also that things from outside the loop were moved into EDIT: That's probably because WGL requires a window to be spawned before building a |
MarijnS95
force-pushed
the
examples-android
branch
from
fc5a351 to
47f98fc
Compare
|
Ah, this was my bad, I think. I must have mistakenly interpreted the old code to re-init every time, but if the purpose of the not-current context is to be reused, then…😅 that's obviously incorrect. |
|
@ErichDonGubler yes, it looks like everyone missed this in review. Probably clobbered by the fact that, on Windows/WGL, a window needs to be created before "making a connection to the compositor" (which is creating the display), which requires There's a whole side-issue on |
When testing the `glutin` example on Android, after suspending and resuming the app no triangle appears. As it turns out the `winit 0.30` bump in rust-windowing#1678 never reuses the `not_current_context` that was set apart in `suspend()`, but creates a new one, without re-running initialization code such as creating the `Renderer`. Partially restore original code before the `winit 0.30` bump, which never created a context in `resume()` because it was already available before the loop started (and moved back in place in `suspend()`). Note also that more initialization code that now (unnecessarily) lives in `resume()` used to be outside of the loop.
MarijnS95
force-pushed
the
examples-android
branch
from
47f98fc to
09396e1
Compare
When testing the
glutinexample on Android, after suspending and resuming the app no triangle appears. As it turns out thewinit 0.30bump in #1678 never reuses thenot_current_contextthat was set apart insuspended(), but creates a new one, without re-running initialization code such as creating theRenderer.Partially restore original code before the
winit 0.30bump, which never created a context inresumed()because it was already available before the loop started (and moved back in place insuspended()). Note also that more initialization code that now (unnecessarily) lives inresumed()used to be outside of the loop.CHANGELOG.mdif knowledge of this change could be valuable to users